feat(rfc_tools): implement semantic RFC number validator CLI - #10
Open
jtmcdole wants to merge 7 commits into
Open
feat(rfc_tools): implement semantic RFC number validator CLI#10jtmcdole wants to merge 7 commits into
jtmcdole wants to merge 7 commits into
Conversation
jtmcdole
force-pushed
the
pr-5-validate-rfc-number
branch
from
September 4, 2026 15:55
6f35c65 to
4d05b5c
Compare
jtmcdole
force-pushed
the
pr-5-validate-rfc-number
branch
from
September 4, 2026 17:13
4d05b5c to
5ec78ed
Compare
jtmcdole
marked this pull request as ready for review
September 4, 2026 17:21
jtmcdole
force-pushed
the
pr-5-validate-rfc-number
branch
from
September 4, 2026 19:33
5ec78ed to
62b17d9
Compare
zanderso
reviewed
Sep 4, 2026
jtmcdole
force-pushed
the
pr-5-validate-rfc-number
branch
2 times, most recently
from
September 4, 2026 22:41
af02b08 to
7f0cc10
Compare
Piinks
reviewed
Sep 8, 2026
| const fs = LocalFileSystem(); | ||
| final validator = RfcValidator(fs: fs); | ||
|
|
||
| final (:isSuccess, :errors) = await validator.validate( |
Collaborator
There was a problem hiding this comment.
If a user runs dart run bin/validate_rfc_number.dart --base-branch upstream/main won't the --base-branch flag be silently ignored because checkMain defaults to false?
Member
Author
There was a problem hiding this comment.
That's correct, and I think I can use args to check that it was actually passed in by a user. Instead of two flags, I'll add one (base-branch) and if its provided, we'll check against it.
Member
Author
There was a problem hiding this comment.
(note to self, make sure the action is updated)
jtmcdole
force-pushed
the
pr-5-validate-rfc-number
branch
from
September 9, 2026 17:06
a5cb20c to
17cdaa4
Compare
jtmcdole
force-pushed
the
pr-5-validate-rfc-number
branch
from
September 10, 2026 00:43
17cdaa4 to
dddfef7
Compare
jtmcdole
force-pushed
the
pr-5-validate-rfc-number
branch
from
September 10, 2026 01:21
dddfef7 to
1ccefe6
Compare
positive string parsing checkBase
jtmcdole
force-pushed
the
pr-5-validate-rfc-number
branch
from
September 10, 2026 02:52
1ccefe6 to
f70bf76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 5 of 7 for testing and automation
Semantic Number Validation
Stack created with GitHub Stacks CLI • Give Feedback 💬